Add labels when using Dockerfile or Compose#929
Open
Roemer wants to merge 2 commits intodevcontainers:mainfrom
Open
Add labels when using Dockerfile or Compose#929Roemer wants to merge 2 commits intodevcontainers:mainfrom
Roemer wants to merge 2 commits intodevcontainers:mainfrom
Conversation
|
I have encountered this error in practice. Hope this error will be fixed soon. |
Contributor
|
We are passing them on here for images: cli/src/spec-node/containerFeatures.ts Line 116 in f475b2b This is missing here: cli/src/spec-node/singleContainer.ts Line 215 in f475b2b It is also missing on the Docker Compose code path. Docker Compose doesn't add labels to the built images, it adds them to the containers. |
Roemer
force-pushed
the
debug/label-in-container-from-dockerfile
branch
from
8969b03 to
c6c1042
Compare
Roemer
force-pushed
the
debug/label-in-container-from-dockerfile
branch
4 times, most recently
from
bc1443b to
fc10eb3
Compare
Author
|
I actually gave it a try and implemented it in this PR, so it is ready for review. |
Roemer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to add labels when using a Dockerfile or Compose.